[webkit-reviews] review denied: [Bug 25808] Create file uri from filename properly : [Attachment 30358] use a proper conversion from filename to uri

[bugzilla-daemon at webkit.org]

Gustavo Noronha (kov) <gns at gnome.org> has denied Fridrich Strba
<fridrich.strba at bluewin.ch>'s request for review:
Bug 25808: Create file uri from filename properly
https://bugs.webkit.org/show_bug.cgi?id=25808

Attachment 30358: use a proper conversion from filename to uri
https://bugs.webkit.org/attachment.cgi?id=30358&action=review

------- Additional Comments from Gustavo Noronha (kov) <gns at gnome.org>
> +#ifndef _WIN32
>      // we avoid the escaping for local files, because
>      // g_filename_from_uri (used internally by GFile) has problems
>      // decoding strings with arbitrary percent signs
>      if (url.isLocalFile())
>	   d->m_gfile = g_file_new_for_path(url.prettyURL().utf8().data() +
sizeof("file://") - 1);
>      else
> +#endif

I think you want to use #if !PLATFORM(WIN_OS) here?

Looks fine otherwise. Also, add a ChangeLog entry, please.