[webkit-reviews] review granted: [Bug 25779] Allow Strings to be created with one malloc node with no copying : [Attachment 30351] Fix

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu May 14 14:00:37 PDT 2009

Darin Adler <darin at apple.com> has granted Dave Moore <davemoore at google.com>'s
request for review:
Bug 25779: Allow Strings to be created with one malloc node with no copying

Attachment 30351: Fix

------- Additional Comments from Darin Adler <darin at apple.com>
> +	   * platform/text/PlatformString.h:
> +	   * platform/text/String.cpp:
> +	   * platform/text/StringImpl.cpp:
> +	   * platform/text/StringImpl.h
> +:

The lists of affected functions are missing. The colon on this last line is on
a separate line.

> +    // Returns an uninitialized string. The characters needs to be written
> +    // into the buffer returned in data before using
> +    static String createUninitialized(unsigned length, UChar*& data);

The comment seems to stop mid-sentence. Or maybe it's just a missing period.

> +String String::createUninitialized(unsigned length, UChar*& data)
> +{
> +    return StringImpl::createUninitialized(length, data);
> +}

This should be inlined. No reason to pay function call overhead here.

r=me as is, but maybe fix those things above and post a new patch?

More information about the webkit-reviews mailing list