[webkit-reviews] review granted: [Bug 25784] Leaks seen on HTTP tests : [Attachment 30320] proposed fix
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu May 14 09:24:24 PDT 2009
Darin Adler <darin at apple.com> has granted Alexey Proskuryakov <ap at webkit.org>'s
request for review:
Bug 25784: Leaks seen on HTTP tests
https://bugs.webkit.org/show_bug.cgi?id=25784
Attachment 30320: proposed fix
https://bugs.webkit.org/attachment.cgi?id=30320&action=review
------- Additional Comments from Darin Adler <darin at apple.com>
> - NSMutableURLRequest *mutableRequest = [request.nsURLRequest()
mutableCopy];
> + NSMutableURLRequest *mutableRequest = [[request.nsURLRequest()
mutableCopy] autorelease];
Clearly this was just introduced by the bug fix for content sniffing. I'd
prefer to find a way to fix this with an additional local variable and a normal
release rather than autorelease.
r=me as is, but consider making it use release instead of autorelease
More information about the webkit-reviews
mailing list