[webkit-reviews] review granted: [Bug 25772] Mac Chromium popup menus are not positioned correctly on scrolled pages : [Attachment 30306] Fix for Mac Chromium popup positioning

[bugzilla-daemon at webkit.org]

Dimitri Glazkov (Google) <dglazkov at chromium.org> has granted Paul Godavari
<paul at chromium.org>'s request for review:
Bug 25772: Mac Chromium popup menus are not positioned correctly on scrolled
pages
https://bugs.webkit.org/show_bug.cgi?id=25772

Attachment 30306: Fix for Mac Chromium popup positioning
https://bugs.webkit.org/attachment.cgi?id=30306&action=review

------- Additional Comments from Dimitri Glazkov (Google)
<dglazkov at chromium.org>
> +	   WARNING: NO TEST CASES ADDED OR CHANGED

Just an FYI: Don't leave this in. It's a reminder for you to make sure you
think of tests :)

Also seems like a Mac-specific method showExternal is not the most elegant
solution, but that's probably beyond the scope of this bug. Can we combine them
or have PopupMenuChromiumMac or something?