[webkit-reviews] review denied: [Bug 25774] Need to upstream V8MessagePortCustom.cpp : [Attachment 30307] patch with upstreamed file

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu May 14 07:45:18 PDT 2009

Eric Seidel <eric at webkit.org> has denied Andrew Wilson <atwilson at google.com>'s
request for review:
Bug 25774: Need to upstream V8MessagePortCustom.cpp

Attachment 30307: patch with upstreamed file

------- Additional Comments from Eric Seidel <eric at webkit.org>
It seems we could share some code between the onMessage and onClose handlers
no?  I think I would have used a static function to make those long if/else
blocks not need to be copy/paste there.  Please feel free to re-mark r=? if I'm
missing something.

Otherwise the code looks sane enough.  createHiddenDependency and
removeHiddenDependency seem confusing... what are they for?

I assume also that this is already covered by existing layout tests?  Otherwise
this needs some form of testing.

More information about the webkit-reviews mailing list