[webkit-reviews] review denied: [Bug 25769] Fix accessibility warnings on GTK : [Attachment 30301] patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed May 13 19:47:31 PDT 2009
Mark Rowe (bdash) <mrowe at apple.com> has denied chris fleizach
<cfleizach at apple.com>'s request for review:
Bug 25769: Fix accessibility warnings on GTK
https://bugs.webkit.org/show_bug.cgi?id=25769
Attachment 30301: patch
https://bugs.webkit.org/attachment.cgi?id=30301&action=review
------- Additional Comments from Mark Rowe (bdash) <mrowe at apple.com>
This isn't correct. The warnings are saying that it doesn't make sense for the
return type of a function to be "const unsigned", such as in "const unsigned
columnCount();". Should that perhaps be "unsigned columnCount() const;"?
More information about the webkit-reviews
mailing list