[webkit-reviews] review granted: [Bug 25616] Add more ENABLE_DATABASE guards. : [Attachment 30272] Adds guards to V8 bindings as well.
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed May 13 06:26:28 PDT 2009
Darin Adler <darin at apple.com> has granted Ben Murdoch <benm at google.com>'s
request for review:
Bug 25616: Add more ENABLE_DATABASE guards.
https://bugs.webkit.org/show_bug.cgi?id=25616
Attachment 30272: Adds guards to V8 bindings as well.
https://bugs.webkit.org/attachment.cgi?id=30272&action=review
------- Additional Comments from Darin Adler <darin at apple.com>
> + Reviewed by NOBODY (OOPS!).
> +
> + Reviewed by NOBODY (OOPS!).
You should not have that in the patch you post.
> + WARNING: NO TEST CASES ADDED OR CHANGED
You should also remove this.
Otherwise this looks fine, r=me
More information about the webkit-reviews
mailing list