[webkit-reviews] review denied: [Bug 19991] WebKit needs cross-platform filter system : [Attachment 30261] prepare SVG FilterEffect

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue May 12 23:37:10 PDT 2009

Eric Seidel <eric at webkit.org> has denied Dirk Schulze <krit at webkit.org>'s
request for review:
Bug 19991: WebKit needs cross-platform filter system

Attachment 30261: prepare SVG FilterEffect

------- Additional Comments from Eric Seidel <eric at webkit.org>
There seems to be no need to copy/paste so much code.  All these effects share
a base class.

I would think the first thing you'd want to do would be to get SVG_FILTERS
turned back on in mainline (by ripping otu the broken code, or spliting the
SVG_FILTERS ifdef into pieces).  But maybe we need more cleanup before we can
do that?

More information about the webkit-reviews mailing list