[webkit-reviews] review granted: [Bug 25729] Alt-clicking a link doesn't start a download : [Attachment 30236] [2/3] Include MK_ALT in the modifier flags when the Alt key is pressed

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue May 12 09:33:32 PDT 2009


Darin Adler <darin at apple.com> has granted Adam Roben (aroben)
<aroben at apple.com>'s request for review:
Bug 25729: Alt-clicking a link doesn't start a download
https://bugs.webkit.org/show_bug.cgi?id=25729

Attachment 30236: [2/3] Include MK_ALT in the modifier flags when the Alt key
is pressed
https://bugs.webkit.org/attachment.cgi?id=30236&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
Seems strange that we have to do this. Normally the job of PlatformEvent
classes is to convert the event from the platform-specific to the
platform-independent form. Having it change the modifier flags that came from
the platform-native event seems outside its responsibilities. I'd expect
clients to use m_altKey and not m_modifierFlags.

r=me though


More information about the webkit-reviews mailing list