[webkit-reviews] review granted: [Bug 21903] input property placeholder should be part of the DOM : [Attachment 30215] Path adding the DOM bindings.
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon May 11 20:50:41 PDT 2009
Eric Seidel <eric at webkit.org> has granted Erik Arvidsson <arv at chromium.org>'s
request for review:
Bug 21903: input property placeholder should be part of the DOM
https://bugs.webkit.org/show_bug.cgi?id=21903
Attachment 30215: Path adding the DOM bindings.
https://bugs.webkit.org/attachment.cgi?id=30215&action=review
------- Additional Comments from Eric Seidel <eric at webkit.org>
Missing your email address in your second ChangeLog.
Tab here:
+ virtual void setPlaceholder(const String&);
which will make the commit fail (pre-commit hook which checks for Tabs in
files).
The test case could have been writen using our js testing framework instead,
but it's fine as is.
I can land this for you and make the tiny fixes when I do.
More information about the webkit-reviews
mailing list