[webkit-reviews] review denied: [Bug 25325] Make sure pthread_self() is declared before it gets called : [Attachment 29680] Proposed fix to include pthread.h in most Unix-like platforms (not just for OPENBSD) in Collector.cpp.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon May 11 20:37:37 PDT 2009


Holger Freyther <zecke at selfish.org> has denied Laszlo Gombos
<laszlo.1.gombos at nokia.com>'s request for review:
Bug 25325: Make sure pthread_self() is declared before it gets called
https://bugs.webkit.org/show_bug.cgi?id=25325

Attachment 29680: Proposed fix to include pthread.h in most Unix-like platforms
(not just for OPENBSD) in Collector.cpp.
https://bugs.webkit.org/attachment.cgi?id=29680&action=review

------- Additional Comments from Holger Freyther <zecke at selfish.org>

>  
>  #if PLATFORM(SOLARIS)
>  #include <thread.h>
> -#endif
> -
> -#if PLATFORM(OPENBSD)
> +#else
>  #include <pthread.h>
>  #endif
>  

I'm not convinced why including this for WINDOWS and DARWIN is a good idea.


More information about the webkit-reviews mailing list