[webkit-reviews] review requested: [Bug 25503] Add instrumentation framework to WebCore : [Attachment 30205] Addresses some comments and rebases against r43514

[bugzilla-daemon at webkit.org]

James Robinson <jamesr at google.com> has asked  for review:
Bug 25503: Add instrumentation framework to WebCore
https://bugs.webkit.org/show_bug.cgi?id=25503

Attachment 30205: Addresses some comments and rebases against r43514
https://bugs.webkit.org/attachment.cgi?id=30205&action=review

------- Additional Comments from James Robinson <jamesr at google.com>
This patch addresses the naming issues with AnalysisClient and creates a
separate didFoo() callback instead of the generic finished() callback.	This
way an implementation only interested in a subset of the instrumentation points
could support only the willFoo()/didFoo() pairs they cared about.

This patch also merges up to r43514 and fixes some whitespace/path issues from
the original patch.  I'll address the other comments raised in the bug
directly.