[webkit-reviews] review granted: [Bug 25348] Change WTF::ThreadIdentifier to be an actual (but wrapped) thread id, remove ThreadMap. : [Attachment 30147] Another attempt. Fixed Safari 4 beta on OSX issue.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon May 11 11:05:14 PDT 2009


Alexey Proskuryakov <ap at webkit.org> has granted Dmitry Titov
<dimich at chromium.org>'s request for review:
Bug 25348: Change WTF::ThreadIdentifier to be an actual (but wrapped) thread
id, remove ThreadMap.
https://bugs.webkit.org/show_bug.cgi?id=25348

Attachment 30147: Another attempt. Fixed Safari 4 beta on OSX issue.
https://bugs.webkit.org/attachment.cgi?id=30147&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
+// The only way to obtain a valid ThreadIdentifier is from createThread(...)
or currentThread() functions.

I'm not a fan of this new comment - it will likely stay there even if we add
other ways.

Looks fine, r=me


More information about the webkit-reviews mailing list