[webkit-reviews] review denied: [Bug 20031] Implement ES 3.1 JSON object : [Attachment 28827] Patch to Add JSON Object
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon May 11 05:58:49 PDT 2009
Eric Seidel <eric at webkit.org> has denied Husam Senussi <husam at senussi.com>'s
request for review:
Bug 20031: Implement ES 3.1 JSON object
https://bugs.webkit.org/show_bug.cgi?id=20031
Attachment 28827: Patch to Add JSON Object
https://bugs.webkit.org/attachment.cgi?id=28827&action=review
------- Additional Comments from Eric Seidel <eric at webkit.org>
This patch uses tabs, which is against the style guidelines (and will cause the
commit to fail).
Please remove the tabs and re-post. Also, I think we could review and land the
tests first and then review the code. Or at least I think they should be
reviewed separately to make the review smaller.
r- for the tabs.
More information about the webkit-reviews
mailing list