[webkit-reviews] review granted: [Bug 25674] syntax tree nodes should use arena allocation : [Attachment 30165] patch for part 1

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun May 10 13:49:50 PDT 2009


Sam Weinig <sam at webkit.org> has granted Darin Adler <darin at apple.com>'s request
for review:
Bug 25674: syntax tree nodes should use arena allocation
https://bugs.webkit.org/show_bug.cgi?id=25674

Attachment 30165: patch for part 1
https://bugs.webkit.org/attachment.cgi?id=30165&action=review

------- Additional Comments from Sam Weinig <sam at webkit.org>
> +	   * parser/NodeConstructors.h: Updated for name change of
parserObjects to
> +	   parserArena. Also added explicit initialization for raw pointers
that used
> +	   to be RawPtr. Also removed some uses of get() that aren't needed now
that

I think you mean, used to be "RefPtr".

r=me


More information about the webkit-reviews mailing list