[webkit-reviews] review requested: [Bug 25348] Change WTF::ThreadIdentifier to be an actual (but wrapped) thread id, remove ThreadMap. : [Attachment 30147] Another attempt. Fixed Safari 4 beta on OSX issue.

[bugzilla-daemon at webkit.org]

Dmitry Titov <dimich at chromium.org> has asked  for review:
Bug 25348: Change WTF::ThreadIdentifier to be an actual (but wrapped) thread
id, remove ThreadMap.
https://bugs.webkit.org/show_bug.cgi?id=25348

Attachment 30147: Another attempt. Fixed Safari 4 beta on OSX issue.
https://bugs.webkit.org/attachment.cgi?id=30147&action=review

------- Additional Comments from Dmitry Titov <dimich at chromium.org>
Same patch, with fix for Safari 4 beta on OSX issue. 
The fix is in ThreadingPthreads.cpp, at the end - I've added a (deprecated)
function waitForThreadCompletion that takes uint32_t instead of
ThreadIdentifier. It has the same decorated name as before so Safari 4 beta
finds the function when it loads it from JavaScriptCore. The other functions,
like CurrentThread() happen to have the same decorated names so no deprecated
functions for them is needed. 
The new ThreadIdentifier is stored inside Safari 4 as uint32_t, and then we
cast it back to pointer. 
Updated JavaScriptCore.exp and JavaScriptCore/ChangeLog accordingly, tested
with Safari 4 beta.