[webkit-reviews] review requested: [Bug 25348] Change WTF::ThreadIdentifier to be an actual (but wrapped) thread id, remove ThreadMap. : [Attachment 30078] Latest - with Win .def files and deprecated functions.
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed May 6 18:12:50 PDT 2009
Dmitry Titov <dimich at chromium.org> has asked for review:
Bug 25348: Change WTF::ThreadIdentifier to be an actual (but wrapped) thread
id, remove ThreadMap.
https://bugs.webkit.org/show_bug.cgi?id=25348
Attachment 30078: Latest - with Win .def files and deprecated functions.
https://bugs.webkit.org/attachment.cgi?id=30078&action=review
------- Additional Comments from Dmitry Titov <dimich at chromium.org>
Thanks a lot for detailed review and advise!
I think I've got it right now, but removing Alexey's r+ and requesting another
look since there are additional changes (hope it's the last!):
- added 'deprecated' functions for Windows, which take the
PlatformThreadIdetifier. Had to change their names too because otherwise some
of them only differ in returning type.
- updated .def files for Windows. Depricated functions are now exported with
rename from WebKit.def so they match their old names. Verified that run-safari
works fine now.
I think this is ready for another look. Thanks!
More information about the webkit-reviews
mailing list