[webkit-reviews] review granted: [Bug 24786] WebKitDownload sometimes suggests peculiar filenames : [Attachment 29257] When a download is requested by an ongoing request, use the already
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed May 6 07:23:16 PDT 2009
Xan Lopez <xan.lopez at gmail.com> has granted Gustavo Noronha (kov)
<gns at gnome.org>'s request for review:
Bug 24786: WebKitDownload sometimes suggests peculiar filenames
https://bugs.webkit.org/show_bug.cgi?id=24786
Attachment 29257: When a download is requested by an ongoing request, use the
already
https://bugs.webkit.org/attachment.cgi?id=29257&action=review
------- Additional Comments from Xan Lopez <xan.lopez at gmail.com>
> + if (!response.isNull() && !response.suggestedFilename().isEmpty()) {
> + g_debug("suggested filename exists!");
> + webkit_download_set_suggested_filename(download,
response.suggestedFilename().utf8().data());
> + }
> +
I guess you want to lose the g_debug. Looks good otherwise.
More information about the webkit-reviews
mailing list