[webkit-reviews] review granted: [Bug 25559] Improve native function call performance : [Attachment 30013] Patcheration

[bugzilla-daemon at webkit.org]

Gavin Barraclough <barraclough at apple.com> has granted Oliver Hunt
<oliver at apple.com>'s request for review:
Bug 25559: Improve native function call performance
https://bugs.webkit.org/show_bug.cgi?id=25559

Attachment 30013: Patcheration
https://bugs.webkit.org/attachment.cgi?id=30013&action=review

------- Additional Comments from Gavin Barraclough <barraclough at apple.com>
loadPtr(Address(X86::esi, FIELD_OFFSET(JSFunction, m_data)), scratchRegister);
call(scratchRegister);

I would recommend not using scratchRegister outside of MacroAssembler, I would
suggest adding call(Address) to avoid requiring a register here at all
(jump(Address) already exists to base this on).

It would be so awesome if functions didn't have a function body node.
So awesome.