[webkit-reviews] review granted: [Bug 25532] Clean up SVG rendering tree more : [Attachment 29979] Add SVGRenderBase to share logic between SVG renderers

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Eric Seidel
<eric at webkit.org>'s request for review:
Bug 25532: Clean up SVG rendering tree more
https://bugs.webkit.org/show_bug.cgi?id=25532

Attachment 29979: Add SVGRenderBase to share logic between SVG renderers
https://bugs.webkit.org/attachment.cgi?id=29979&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
>  // Most renderers in the SVG rendering tree will inherit from this class
>  // but not all. (e.g. RenderSVGForeignObject, RenderSVGBlock,
RenderSVGImage) thus methods
> -// required by SVG renders need to be declared on RenderObject, but some
shared
> -// logic can go in this class.
> +// required by SVG renders need to be declared on RenderObject, but shared
> +// logic can go in this class or in SVGRenderBase.

You should give some direction about why one or the other is appropriate.