[webkit-reviews] review granted: [Bug 17066] [GTK] Improve frameloader signals : [Attachment 27001] Implement load-status and progress properties

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon May 4 17:24:15 PDT 2009

Gustavo Noronha (kov) <gns at gnome.org> has granted Christian Dywan
<christian at twotoasts.de>'s request for review:
Bug 17066: [GTK] Improve frameloader signals

Attachment 27001: Implement load-status and progress properties

------- Additional Comments from Gustavo Noronha (kov) <gns at gnome.org>
>  #include "webkitwebframe.h"
>  #include "webkitwebview.h"
> +#include "webkitenumtypes.h"
>  #include "webkitmarshal.h"
>  #include "webkitprivate.h"

This header addition is not in the correct order.

> +    * Since: 1.1.1

We now need to use 1.1.7 here =).

> --- a/WebKitTools/GtkLauncher/main.c
> +++ b/WebKitTools/GtkLauncher/main.c

All changes to the launcher look good to me, but please put them in another

>      gtk_init (&argc, &argv);
> +    if (!g_thread_supported ())
> +	   g_thread_init (NULL);

And this is no longer needed, but you know this, of course =).

The patch looks good, and since we have already had lots of discussion on this
already, so I'll r+ and you can address my comments while landing.

More information about the webkit-reviews mailing list