[webkit-reviews] review requested: [Bug 25351] Enable copying image to the clipboard : [Attachment 29719] enable copying image to clipboard

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon May 4 16:46:10 PDT 2009


Gustavo Noronha (kov) <gns at gnome.org> has asked Eric Seidel <eric at webkit.org>
for review:
Bug 25351: Enable copying image to the clipboard
https://bugs.webkit.org/show_bug.cgi?id=25351

Attachment 29719: enable copying image to clipboard
https://bugs.webkit.org/attachment.cgi?id=29719&action=review

------- Additional Comments from Gustavo Noronha (kov) <gns at gnome.org>
(In reply to comment #2)
> (From update of attachment 29719 [review])
> Looks wrong.	Why is it OK to ASSERT here in the gtk version and not in the
mac
> version?

>From my reading of the code, the same ASSERT's exist in Mac. Am I missing
something?:

void Pasteboard::writeImage(Node* node, const KURL& url, const String& title)
{
    ASSERT(node);
[...]
    ASSERT(node->renderer() && node->renderer()->isImage());
[...]
    ASSERT(cachedImage);
[...]
    ASSERT(image);
[...]
}


More information about the webkit-reviews mailing list