[webkit-reviews] review denied: [Bug 24260] Loading progress for blank views : [Attachment 28958] possible fix for policy crash

[bugzilla-daemon at webkit.org]

Gustavo Noronha (kov) <gns at gnome.org> has denied Christian Dywan
<christian at twotoasts.de>'s request for review:
Bug 24260: Loading progress for blank views
https://bugs.webkit.org/show_bug.cgi?id=24260

Attachment 28958: possible fix for policy crash
https://bugs.webkit.org/attachment.cgi?id=28958&action=review

------- Additional Comments from Gustavo Noronha (kov) <gns at gnome.org>
> -    if (!priv->isCancelled)
> +    if (!priv->isCancelled) {
>	  
(core(priv->frame)->loader()->*(priv->framePolicyFunction))(WebCore::PolicyUse)
;
> +	   priv->isCancelled = TRUE;

This looks very weird to me. Perhaps what we need is another private member
that says alreadyDecided? Then if we have alreadyDecided == TRUE we g_warning
that a decision has already been implemented, what do you think? I'll say r-
for now.