[webkit-reviews] review denied: [Bug 24260] Loading progress for blank views : [Attachment 28369] This corrects mime and navigation handling #2

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon May 4 16:23:09 PDT 2009

Gustavo Noronha (kov) <gns at gnome.org> has denied Christian Dywan
<christian at twotoasts.de>'s request for review:
Bug 24260: Loading progress for blank views

Attachment 28369: This corrects mime and navigation handling #2

------- Additional Comments from Gustavo Noronha (kov) <gns at gnome.org>
>      if (!isHandled)
>	   webkit_web_policy_decision_use(m_policyDecision);
> +    else
> +	   webkit_web_policy_decision_ignore(m_policyDecision);
>  }

As has already been stated, I believe if you handle the signal you must take
one of the decisions. Otherwise you should return FALSE. I'd rather improve the
docs to say that. Of course we also need to make sure calling them twice will
not go boom, though. The other changes look good to me, so I'll say r- to the
patch, but rs=me to change the policy function calls for API ones, and add that
explanation to the docs.

More information about the webkit-reviews mailing list