[webkit-reviews] review denied: [Bug 25544] toString (function source) for event listeners in V8 bindings shows wrapper code : [Attachment 29988] Patch to fix the issue.
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon May 4 05:35:56 PDT 2009
Eric Seidel <eric at webkit.org> has denied 's request for review:
Bug 25544: toString (function source) for event listeners in V8 bindings shows
wrapper code
https://bugs.webkit.org/show_bug.cgi?id=25544
Attachment 29988: Patch to fix the issue.
https://bugs.webkit.org/attachment.cgi?id=29988&action=review
------- Additional Comments from Eric Seidel <eric at webkit.org>
In general if you need a review, you need to mark things with r=? otherwise
they won't appear in the queue.
There are several typos in the changelog.
This needs a test added to LayoutTests (probably in LayoutTests/fast/js)
String::append is generally a slow way to build strings, StringBuilder or
Vector<UChar> is faster. But in this case it may not matter.
r- for lack of test.
More information about the webkit-reviews
mailing list