[webkit-reviews] review denied: [Bug 24001] [GTK] Cache control APIs : [Attachment 27745] This patch adds a boolean page-cache property to WebSettings for enabling/disabling the use of page cache

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon May 4 04:50:57 PDT 2009


Gustavo Noronha (kov) <gns at gnome.org> has denied 's request for review:
Bug 24001: [GTK] Cache control APIs
https://bugs.webkit.org/show_bug.cgi?id=24001

Attachment 27745: This patch adds a boolean page-cache property to WebSettings
for enabling/disabling the use of page cache
https://bugs.webkit.org/attachment.cgi?id=27745&action=review

------- Additional Comments from Gustavo Noronha (kov) <gns at gnome.org>
I believe this property should be called enable-page-cache, to match the other
properties which are similar in behavior. I think it is good to improve the
comment which describes the property, too, to explain what the page cache is,
and that disabling it doesn't disable all caching, but looks otherwise good to
me. I'll have Xan take a look, since this is public API.


More information about the webkit-reviews mailing list