[webkit-reviews] review granted: [Bug 24704] DumpRenderTree (OSX version) should be able to run independent instances at the same time. : [Attachment 28863] Proposed fix.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon May 4 01:26:55 PDT 2009


Eric Seidel <eric at webkit.org> has granted David Levin <levin at chromium.org>'s
request for review:
Bug 24704: DumpRenderTree (OSX version) should be able to run independent
instances at the same time.
https://bugs.webkit.org/show_bug.cgi?id=24704

Attachment 28863: Proposed fix.
https://bugs.webkit.org/attachment.cgi?id=28863&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
It seems saving things to:
~/Library/tmp is silly.  ~/Library/Application Support/DumpRenderTree or
~/Library/Caches/DumpRenderTree would make more sense.

Otherwise this looks fine.  Mark should feel encouraged to comment further, but
this looks like a big step forward for our testing.  Even if it's not perfect
final layout, it's much better than what we have today (in terms of that it
moves us closer to running tests in parallel).


More information about the webkit-reviews mailing list