[webkit-reviews] review granted: [Bug 25520] Do not instantiate hidden WebInspector panels. : [Attachment 29963] patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Sun May 3 03:33:00 PDT 2009
Timothy Hatcher <timothy at hatcher.name> has granted Pavel Feldman
<pfeldman at chromium.org>'s request for review:
Bug 25520: Do not instantiate hidden WebInspector panels.
https://bugs.webkit.org/show_bug.cgi?id=25520
Attachment 29963: patch
https://bugs.webkit.org/attachment.cgi?id=29963&action=review
------- Additional Comments from Timothy Hatcher <timothy at hatcher.name>
This looks good. A couple code style things i would like to see changed that
I want to put in our official style rules.
1. Use "===" or "!--" when you know the types already match.
2. Use double quotes fore al string literals.
More information about the webkit-reviews
mailing list