[webkit-reviews] review granted: [Bug 25496] Switch V8EventListenerList to a hashtable implementation : [Attachment 29950] patch v3

[bugzilla-daemon at webkit.org]

Dimitri Glazkov (Google) <dglazkov at chromium.org> has granted Antony Sargent
<asargent at chromium.org>'s request for review:
Bug 25496: Switch V8EventListenerList to a hashtable implementation
https://bugs.webkit.org/show_bug.cgi?id=25496

Attachment 29950: patch v3
https://bugs.webkit.org/attachment.cgi?id=29950&action=review

------- Additional Comments from Dimitri Glazkov (Google)
<dglazkov at chromium.org>
You did good! Just a few comments below.

> +	   No new functionality so no new tests.
> +
> +	   * bindings/v8/V8EventListenerList.cpp:
> +	   (WebCore::V8EventListenerListIterator::V8EventListenerListIterator):

> +	  
(WebCore::V8EventListenerListIterator::~V8EventListenerListIterator):
> +	   (WebCore::V8EventListenerListIterator::operator++):
> +	   (WebCore::V8EventListenerListIterator::operator==):
> +	   (WebCore::V8EventListenerListIterator::operator!=):
> +	   (WebCore::V8EventListenerListIterator::operator*):
> +	   (WebCore::V8EventListenerListIterator::seekToEnd):
> +	   (WebCore::V8EventListenerList::V8EventListenerList):
> +	   (WebCore::V8EventListenerList::~V8EventListenerList):
> +	   (WebCore::V8EventListenerList::begin):
> +	   (WebCore::V8EventListenerList::end):
> +	   (WebCore::getKey):
> +	   (WebCore::V8EventListenerList::add):
> +	   (WebCore::V8EventListenerList::remove):
> +	   (WebCore::V8EventListenerList::clear):
> +	   (WebCore::V8EventListenerList::find):

No need to leave all these hanging. Can just say:

 +	  * bindings/v8/V8EventListenerList.cpp: Added
V8EventListenerListIterator.

> +int getKey(v8::Local<v8::Object> object)

static int getKey(...