[webkit-reviews] review denied: [Bug 25252] REGRESSION (r41469): mis-layout at endless.com before window resize : [Attachment 29936] Roll out r41469

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri May 1 10:12:59 PDT 2009


Eric Seidel <eric at webkit.org> has denied 's request for review:
Bug 25252: REGRESSION (r41469): mis-layout at endless.com before window resize
https://bugs.webkit.org/show_bug.cgi?id=25252

Attachment 29936: Roll out r41469
https://bugs.webkit.org/attachment.cgi?id=29936&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
This roll out covers more than I changed.  I don't remember making any changes
to

     // Grab the arena from node()->document()->renderArena() before clearing
the node pointer.
103	 // Clear the node before deref-ing, as this may be deleted when deref
is called.
104	 RenderArena* arena = renderArena();
 99	if (style() && (style()->height().isPercent() ||
style()->minHeight().isPercent() || style()->maxHeight().isPercent()))
 100	     RenderBlock::removePercentHeightDescendant(this);

http://trac.webkit.org/changeset/41469


More information about the webkit-reviews mailing list