[webkit-reviews] review denied: [Bug 24897] Chromium's ResourceRequest and ResourceResponse structs need some new data members. : [Attachment 29030] new patch snapshot #2

[bugzilla-daemon at webkit.org]

Darin Fisher (:fishd, Google) <fishd at chromium.org> has denied Michael Nordman
<michaeln at google.com>'s request for review:
Bug 24897: Chromium's ResourceRequest and ResourceResponse structs need some
new data members.
https://bugs.webkit.org/show_bug.cgi?id=24897

Attachment 29030: new patch snapshot #2
https://bugs.webkit.org/attachment.cgi?id=29030&action=review

------- Additional Comments from Darin Fisher (:fishd, Google)
<fishd at chromium.org>
OK.  Thanks for adding the reference to the Chromium CL here.  That helps
others understand this design as well :)


>Index: WebCore/ChangeLog

>+	  Chromium's ResourceRequest and ResourceResponse structs need some new
data members.
>+
>+	  These fields are needed to facilitate Chromium's implementation of
the HTML5
>+	  ApplicationCache feature. We need to know what frame(or context) is
doing the

nit: Need a space after "frame"


>+	  requesting, and from what cache the resulting resource was retrieved.

>+
>+	  No change in functionality, so no tests.

Please include a bug link in your ChangeLog entry.


>Index: WebCore/platform/network/chromium/ResourceResponse.h

>+	  // The id of the appcache this response was retrieved from,
>+	  // or kNoAppCacheID (0)
>+	  int64 m_appCacheID;

Where is kNoAppCacheID defined?  also, how come the contextID is 32-bits but
the CacheID is 64-bits?