[webkit-reviews] review granted: [Bug 24966] Move RangeBoundaryPoint off of Position : [Attachment 29137] Move RangeBoundaryPoint off of Position, per Darin's suggestion

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Mar 31 15:53:28 PDT 2009


Darin Adler <darin at apple.com> has granted Eric Seidel <eric at webkit.org>'s
request for review:
Bug 24966: Move RangeBoundaryPoint off of Position
https://bugs.webkit.org/show_bug.cgi?id=24966

Attachment 29137: Move RangeBoundaryPoint off of Position, per Darin's
suggestion
https://bugs.webkit.org/attachment.cgi?id=29137&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
Looks good.

r=me

Do we need RangeBoundaryPoint::toPosition()? I think RangeBoundaryPoint may be
a lower level class than Position, so conversion to a Position might insteadCan
we get rid of Range::startPosition and Range::endPosition?


More information about the webkit-reviews mailing list