[webkit-reviews] review granted: [Bug 24965] HTMLMediaElement: network state changes can be missed : [Attachment 29132] proposed patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Mar 31 15:10:34 PDT 2009

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Eric Carlson
<eric.carlson at apple.com>'s request for review:
Bug 24965: HTMLMediaElement: network state changes can be missed

Attachment 29132: proposed patch

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
> +	       MediaPlayer::ReadyState currentState = m_player->readyState();
> +	       if (static_cast<ReadyState>(currentState) != m_readyState)

This cast is pretty heinous. It would be nice to:
1. Have MediaPlayer ReadyState have a somewhat different name
2. Have a method that converts them: ReadyState
readyStateForPlayerReadyState(PlayerReadyState) rather than casting.

But those can be done in a later commit.

More information about the webkit-reviews mailing list