[webkit-reviews] review denied: [Bug 24315] WMLInputElement.cpp produces build-time error : [Attachment 29112] Fix build errors with WMLInputElement.cpp

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Mar 31 10:12:05 PDT 2009


Darin Adler <darin at apple.com> has denied Sam Black <samwwwblack at gmail.com>'s
request for review:
Bug 24315: WMLInputElement.cpp produces build-time error
https://bugs.webkit.org/show_bug.cgi?id=24315

Attachment 29112: Fix build errors with WMLInputElement.cpp
https://bugs.webkit.org/attachment.cgi?id=29112&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
Casts should use the new checked cast toRenderTextControl, not a direct
static_cast.

It's not clear why you're calling isTextField in one case and not the other.
It's not needed in either case since this class always creates a renderer
derived from RenderTextControl.


More information about the webkit-reviews mailing list