[webkit-reviews] review denied: [Bug 24908] run-webkit-tests unable to set timeout manually : [Attachment 29107] Fix argument order, --timeout instead of --timeout-seconds

[bugzilla-daemon at webkit.org]

Adam Roben (aroben) <aroben at apple.com> has denied Brian Weinstein
<bweinstein at gmail.com>'s request for review:
Bug 24908: run-webkit-tests unable to set timeout manually
https://bugs.webkit.org/show_bug.cgi?id=24908

Attachment 29107: Fix argument order, --timeout instead of --timeout-seconds
https://bugs.webkit.org/attachment.cgi?id=29107&action=review

------- Additional Comments from Adam Roben (aroben) <aroben at apple.com>
> +  --timeout			     Sets the length of time before a test
times out

The Usage output should indicate that --timeout takes a parameter. It would be
good for it to also say what the default value is.

> +    'timeout-seconds=i' => \$timeoutSeconds,

This wasn't changed to match the new name of the option.

Your ChangeLog should also mention that this patch changes the default value
back to 60 seconds from 15. Or your patch keep the default at 15 seconds (which
might be better).

r- since the code doesn't match the Usage statement.