[webkit-reviews] review granted: [Bug 24946] right clicking on selected text de-selects the text in chromium/gtk+ ports : [Attachment 29090] svn version

[bugzilla-daemon at webkit.org]

Darin Fisher (:fishd, Google) <fishd at chromium.org> has granted Tony Chang
(Google) <tony at chromium.org>'s request for review:
Bug 24946: right clicking on selected text de-selects the text in chromium/gtk+
ports
https://bugs.webkit.org/show_bug.cgi?id=24946

Attachment 29090: svn version
https://bugs.webkit.org/attachment.cgi?id=29090&action=review

------- Additional Comments from Darin Fisher (:fishd, Google)
<fishd at chromium.org>
This change seems simple and correct to me.  r+


> Index: LayoutTests/fast/events/context-no-deselect.html
...
> +if (window.layoutTestController) {
> +	var x, y;
> +	x = input.offsetParent.offsetLeft + input.offsetLeft +
input.offsetWidth / 2;
> +	y = input.offsetParent.offsetTop + input.offsetTop + input.offsetHeight
/ 2;
> +	eventSender.mouseMoveTo(x, y);
> +	eventSender.contextClick();

nit: indentation should be 4 spaces.  please fix this before landing.


why is it correct to copy the results from
LayoutTests/platform/mac/fast/repaint/renderer-destruction-by-invalidateSelecti
on-crash.html?	that test seems to have a very different rendering.