[webkit-reviews] review requested: [Bug 24947] Special-case chromium drawing text-shadow when opaque color & no shadow blur : [Attachment 29101] Changes from Comment #6 (Eric Seidel)

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Mar 30 17:55:01 PDT 2009


Rafael Weinstein <rafaelw at chromium.org> has asked  for review:
Bug 24947: Special-case chromium drawing text-shadow when opaque color & no
shadow blur
https://bugs.webkit.org/show_bug.cgi?id=24947

Attachment 29101: Changes from Comment #6 (Eric Seidel)
https://bugs.webkit.org/attachment.cgi?id=29101&action=review

------- Additional Comments from Rafael Weinstein <rafaelw at chromium.org>
-ASSERT()s used rather than second check of windowCanHandleDrawTextShadow()
-tempColor -> textColor
-saveColor -> savedTextColor
-formatting
-"context" removed from function declaration of both *canHandle*Text functions


More information about the webkit-reviews mailing list