[webkit-reviews] review denied: [Bug 24947] Special-case chromium drawing text-shadow when opaque color & no shadow blur : [Attachment 29088] Let GDI draw text-shadow on opaque colors and 0 blur

[bugzilla-daemon at webkit.org]

Darin Fisher (:fishd, Google) <fishd at chromium.org> has denied 's request for
review:
Bug 24947: Special-case chromium drawing text-shadow when opaque color & no
shadow blur
https://bugs.webkit.org/show_bug.cgi?id=24947

Attachment 29088: Let GDI draw text-shadow on opaque colors and 0 blur
https://bugs.webkit.org/attachment.cgi?id=29088&action=review

------- Additional Comments from Darin Fisher (:fishd, Google)
<fishd at chromium.org>
>Index: ChangeLog
...
>+	  Reviewed by NOBODY (OOPS!).
>+
>+	Special-case drawing text-shadow on win32, to let GDI draw in cases
when both fill & 
>+	shadow color are opaque and the shadow has no blur.

replace tabs with spaces.


>Index: platform/graphics/chromium/FontChromiumWin.cpp

>+    IntSize shadow_size;
>+    int shadow_blur;
>+    Color shadow_color;

please use webkit style for naming variables:
http://webkit.org/coding/coding-style.html


>Index: platform/graphics/skia/SkiaFontWin.cpp

>+bool windowsCanHandleDrawTextShadow(WebCore::GraphicsContext *context) {
>+    IntSize shadow_size;
>+    int shadow_blur;
>+    Color shadow_color;

ditto