[webkit-reviews] review requested: [Bug 24946] right clicking on selected text de-selects the text in chromium/gtk+ ports : [Attachment 29089] [1/1] Ensure the right click doesn't deselect text under it. This was

[bugzilla-daemon at webkit.org]

Tony Chang (Google) <tony at chromium.org> has asked  for review:
Bug 24946: right clicking on selected text de-selects the text in chromium/gtk+
ports
https://bugs.webkit.org/show_bug.cgi?id=24946

Attachment 29089: [1/1] Ensure the right click doesn't deselect text under it. 
This was
https://bugs.webkit.org/attachment.cgi?id=29089&action=review

------- Additional Comments from Tony Chang (Google) <tony at chromium.org>
happening in the Chromium and GTK+ ports because they don't select
the text under the cursor on right click.

This was regressed in r41715, https://bugs.webkit.org/show_bug.cgi?id=19737

https://bugs.webkit.org/show_bug.cgi?id=24946
---
 LayoutTests/ChangeLog				    |	17 ++++++++++++++
 LayoutTests/fast/events/context-no-deselect.html   |	23 ++++++++++++++++++++
 .../events/context-no-deselect-expected.checksum   |	 1 +
 .../fast/events/context-no-deselect-expected.png   |  Bin 0 -> 13759 bytes
 .../fast/events/context-no-deselect-expected.txt   |	16 +++++++++++++
 WebCore/ChangeLog				    |	17 ++++++++++++++
 WebCore/page/EventHandler.cpp			    |	10 +++++---
 7 files changed, 80 insertions(+), 4 deletions(-)