[webkit-reviews] review denied: [Bug 24903] Text files which have sub MIME types are treated as not displayable : [Attachment 29084] Recognize any text/* type

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has denied Christian Dywan
<christian at twotoasts.de>'s request for review:
Bug 24903: Text files which have sub MIME types are treated as not displayable
https://bugs.webkit.org/show_bug.cgi?id=24903

Attachment 29084: Recognize any text/* type
https://bugs.webkit.org/attachment.cgi?id=29084&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
Needs a change log.

Change looks good. I don't understand why these functions are case sensitive,
but they are, so the new code matches what's already here.

Besides "text/", you should remove all the "text/*" MIME types from
initializeSupportedNonImageMimeTypes because none of them do us any good. That
includes "text/vnd.wap.wml" as well as the others that are not inside an ifdef.


Can you write a regression test too? There should be a way to test this in our
HTTP tests if not the plain text tests.

review- because of lack of a change log and the other issues mentioned above.