[webkit-reviews] review granted: [Bug 24878] [GTK] Use GtkBinding system to handle key events in WebView : [Attachment 29005] webviewbindings.patch

[bugzilla-daemon at webkit.org]

Holger Freyther <zecke at selfish.org> has granted Xan Lopez
<xan.lopez at gmail.com>'s request for review:
Bug 24878: [GTK] Use GtkBinding system to handle key events in WebView
https://bugs.webkit.org/show_bug.cgi?id=24878

Attachment 29005: webviewbindings.patch
https://bugs.webkit.org/attachment.cgi?id=29005&action=review

------- Additional Comments from Holger Freyther <zecke at selfish.org>

> +    case GTK_MOVEMENT_VISUAL_POSITIONS:
> +	   if (count == 1)
> +	       view->scrollBy(IntSize(cScrollbarPixelsPerLineStep, 0));
> +	   else if (count == -1)
> +	       view->scrollBy(IntSize(-cScrollbarPixelsPerLineStep, 0));
> +	 break;

wrongly placed.



yeah!!!