[webkit-reviews] review granted: [Bug 24922] change WorkQueue-based navigation tests to not depend on synchronous form submission : [Attachment 29046] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Mar 29 10:04:05 PDT 2009


Cameron Zwarich (cpst) <cwzwarich at uwaterloo.ca> has granted Darin Adler
<darin at apple.com>'s request for review:
Bug 24922: change WorkQueue-based navigation tests to not depend on synchronous
form submission
https://bugs.webkit.org/show_bug.cgi?id=24922

Attachment 29046: patch
https://bugs.webkit.org/attachment.cgi?id=29046&action=review

------- Additional Comments from Cameron Zwarich (cpst)
<cwzwarich at uwaterloo.ca>
> // Not dumping as text since the DumpRenderTree does not dump the text
conetnt of child frames.

There is a typo here: "conetnt" should be "content". After runTest() there
should probably be a blank line before subframeLoaded(), but I am not sure how
strict we are on style in test files.

Other than that, r=me.


More information about the webkit-reviews mailing list