[webkit-reviews] review requested: [Bug 24917] Fix/Enable turning off JavaScript Debugger : [Attachment 29041] Fix/Enable turning off JavaScript Debugger

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Mar 28 20:36:19 PDT 2009


Laszlo Gombos <laszlo.1.gombos at nokia.com> has asked  for review:
Bug 24917: Fix/Enable turning off JavaScript Debugger
https://bugs.webkit.org/show_bug.cgi?id=24917

Attachment 29041: Fix/Enable turning off JavaScript Debugger
https://bugs.webkit.org/attachment.cgi?id=29041&action=review

------- Additional Comments from Laszlo Gombos <laszlo.1.gombos at nokia.com>
Made an attempt to make sure that in all ports JavaScript Debugger support
remains as it was before the patch.

Introduced guards not only where the JavaScript Debugger is used, but also in
JavaScript Debugger implementation itself - to stay consistent with other
feature flags, like the App Cache (e.g. see
http://trac.webkit.org/browser/trunk/WebCore/loader/appcache/ApplicationCacheSt
orage.h)

Enable the Gtk and Qt ports to turn off JavaScript Debugger support, other
ports can enable turning off JavaScript Debugger support later (if there is
interest).


More information about the webkit-reviews mailing list