[webkit-reviews] review denied: [Bug 24457] Extend Qtish API with functionality of finding all occurences of particular phrase and highlighting them. : [Attachment 28409] patch

[bugzilla-daemon at webkit.org]

Simon Hausmann <hausmann at webkit.org> has denied Jakub Wieczorek
<faw217 at gmail.com>'s request for review:
Bug 24457: Extend Qtish API with functionality of finding all occurences of
particular phrase and highlighting them.
https://bugs.webkit.org/show_bug.cgi?id=24457

Attachment 28409: patch
https://bugs.webkit.org/attachment.cgi?id=28409&action=review

------- Additional Comments from Simon Hausmann <hausmann at webkit.org>
I think it would be better to not add a new method but to add
FindAllOccurrences to the FindFlags instead.

Instead of adding resetTextHighlight(), what do you think about caling
unmarkAllTextMatches() if findText() is called with an empty string?