[webkit-reviews] review denied: [Bug 24851] Failures in http/tests/xhlhttprequest/web-apps : [Attachment 28992] Update to web-apps test result and skip list

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Mar 26 23:30:29 PDT 2009

Alexey Proskuryakov <ap at webkit.org> has denied Brian Weinstein
<bweinstein at gmail.com>'s request for review:
Bug 24851: Failures in http/tests/xhlhttprequest/web-apps

Attachment 28992: Update to web-apps test result and skip list

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
The problem here is that XMLHttpRequest.statusText includes the status code
(e.g. it's "400 Good work" instead of "Good Work"). Looking at
ResourceResponse::platformLazyInit(), it has an obvious bug, removing only
"HTTP/1.1" from a response such as "HTTP/1.1 400 Good Work":

	RetainPtr<CFStringRef> statusLine(AdoptCF,
	String statusText(statusLine.get());
	int spacePos = statusText.find(" ");
	if (spacePos != -1)
	    statusText = statusText.substring(spacePos + 1);
	m_httpStatusText = statusText;

Looks like this is easier to fix than to land failing results.

More information about the webkit-reviews mailing list