[webkit-reviews] review granted: [Bug 24616] Add custom V8 bindings for DOMWindow : [Attachment 28972] patch w/ Dimitri's comments

[bugzilla-daemon at webkit.org]

Dimitri Glazkov (Google) <dglazkov at chromium.org> has granted Mike Belshe
<mike at belshe.com>'s request for review:
Bug 24616: Add custom V8 bindings for DOMWindow
https://bugs.webkit.org/show_bug.cgi?id=24616

Attachment 28972: patch w/ Dimitri's comments
https://bugs.webkit.org/attachment.cgi?id=28972&action=review

------- Additional Comments from Dimitri Glazkov (Google)
<dglazkov at chromium.org>
Good enough. The following are nice, but not required.

> +    return v8::Handle<v8::Value>();

notHandledByInterceptor()

> +    if (!name->IsString())
> +	   return v8::Handle<v8::Value>();

notHandledByInterceptor()

> +    if (holder.IsEmpty())
> +	   return v8::Handle<v8::Value>();

notHandledByInterceptor()


> +    if (!window)
> +	   return v8::Handle<v8::Value>();

notHandledByInterceptor()


> +    Frame* frame = window->frame();
> +    // window is detached from a frame.
> +    if (!frame)
> +	   return v8::Handle<v8::Value>();

notHandledByInterceptor()


> +
> +    return v8::Handle<v8::Value>();

notHandledByInterceptor()