[webkit-reviews] review denied: [Bug 24767] reduce number of calls to String::append in V8LazyEventListener : [Attachment 28873] patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Mar 26 11:41:41 PDT 2009
Eric Seidel <eric at webkit.org> has denied Antony Sargent
<asargent at chromium.org>'s request for review:
Bug 24767: reduce number of calls to String::append in V8LazyEventListener
https://bugs.webkit.org/show_bug.cgi?id=24767
Attachment 28873: patch
https://bugs.webkit.org/attachment.cgi?id=28873&action=review
------- Additional Comments from Eric Seidel <eric at webkit.org>
Is this the proper multi-line string syntax? i.e. why were there \ before but
not now?
We have a String::printf I think, wouldn't that be more efficient than this 3
appends? You might actually want to use StringBuilder here instead, or just a
Vector<UChar>
Also, this should be "const char*" in WebKit style.
More information about the webkit-reviews
mailing list