[webkit-reviews] review granted: [Bug 21597] Set popup's location to about:blank while it's loading : [Attachment 28569] Patch w/ Darin's comments

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has granted Mike Belshe <mike at belshe.com>'s
request for review:
Bug 21597: Set popup's location to about:blank while it's loading
https://bugs.webkit.org/show_bug.cgi?id=21597

Attachment 28569: Patch w/ Darin's comments
https://bugs.webkit.org/attachment.cgi?id=28569&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
I think that this change looks fine, but we should make an effort to better
document the behavior of the other browsers in the test or code change for when
the next person looks at this. ;)

Specifically, there are comments about what FF does
location-new-window-no-crash.js we might as well add the information mike
learned in his testing of IE8 to the same comment lines when landing.

I've CC'd Darin (and Alexey was already cc'd) so they have the opportunity to
point out any subtlety which they had in mind, but didn't mention in the bug.