[webkit-reviews] review granted: [Bug 16482] Hook up ICU's encoding detector and add a boolean param to Settings and WebPreferences : [Attachment 28952] patch addressing ap's concerns

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Mar 25 23:09:56 PDT 2009


Alexey Proskuryakov <ap at webkit.org> has granted Jungshik Shin
<jshin at chromium.org>'s request for review:
Bug 16482: Hook up ICU's encoding detector and add a boolean param to Settings
and WebPreferences
https://bugs.webkit.org/show_bug.cgi?id=16482

Attachment 28952: patch addressing ap's concerns
https://bugs.webkit.org/attachment.cgi?id=28952&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
r=me

I prefer this version, because it uses less memory (this is not critical,
because TextResourceDecoder objects are not too numerous, but a good practice
anyway).


More information about the webkit-reviews mailing list