[webkit-reviews] review denied: [Bug 24785] Move CSS AtomicStrings into static AtomicStrings : [Attachment 28921] patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Mar 25 18:11:53 PDT 2009
Eric Seidel <eric at webkit.org> has denied Mike Belshe <mike at belshe.com>'s
request for review:
Bug 24785: Move CSS AtomicStrings into static AtomicStrings
https://bugs.webkit.org/show_bug.cgi?id=24785
Attachment 28921: patch
https://bugs.webkit.org/attachment.cgi?id=28921&action=review
------- Additional Comments from Eric Seidel <eric at webkit.org>
If you went the CSSNames route, the make_names.pl script is what you'd want to
use. It would do all this for you. Then you'd just add a CSsNames.in file
somewhere.
But I think you probably want to use this construct instead:
DEFINE_STATIC_LOCAL(AtomicString, anyLink, ("-webkit-any-link"));
It's simpler. It's our hack around the static local problem as far as I
understand it. We used to use static locals until recently that macro was
added.
More information about the webkit-reviews
mailing list